[Perf][WhitespaceLinter] Use hand crafted "is whitespace" function #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `UnicodeScalar(_:)` on arbitrary UTF8 code point was wrong. It only works correctly if the code point is < 0x80 * `UnicodeScalar.Properties.isWhitespace` is slow. Profiling 'lint' shows it's taking 13.6 of the entire time * Whitespaces in Unicode "Basic Latin" block are well defined, there's no need to consult `UnicodeScalar.Properties`
rintaro
requested review from
ahoppen,
allevato,
bnbarham and
shawnhyam
as code owners
|
@swift-ci Please test |
allevato
approved these changes
Jan 13, 2025
bnbarham
approved these changes
Jan 13, 2025
|
Nice, thanks @rintaro! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UnicodeScalar(_:)on arbitrary UTF8 code point was wrong. It only works correctly if the code point is < 0x80UnicodeScalar.Properties.isWhitespaceis slow. Profilinglintshowed it was taking 13.6% of the entire run timeUnicodeScalar.Properties